Change NameOrNumberTree.getAll to return a Map rather than an Object
#13283
Conversation
Given that we're (almost) always iterating through the result of the `getAll`-calls, using a `Map` seems nicer overall since it's more suited to iteration compared to a regular Object. Also, add a couple of `Dict`-checks in existing code touched by this patch, since it really cannot hurt to prevent *potential* errors in a corrupt PDF document.
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a3bcef7677d33d6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/b906f04cd0db98d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/a3bcef7677d33d6/output.txt Total script time: 25.70 mins
Image differences available at: http://54.67.70.0:8877/a3bcef7677d33d6/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/b906f04cd0db98d/output.txt Total script time: 29.70 mins
Image differences available at: http://3.101.106.178:8877/b906f04cd0db98d/reftest-analyzer.html#web=eq.log |
This patch first of all moves all checking/validation into the `appendIfJavaScriptDict` function, to avoid duplicating it in multiple places. Secondly, also removes what's now an outdated/incorrect comment since we have implemented scripting support.
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/108e0754742f137/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/1d9c010c145d703/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/108e0754742f137/output.txt Total script time: 25.62 mins
Image differences available at: http://54.67.70.0:8877/108e0754742f137/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/1d9c010c145d703/output.txt Total script time: 28.87 mins
Image differences available at: http://3.101.106.178:8877/1d9c010c145d703/reftest-analyzer.html#web=eq.log |
|
Looks good; thanks! |
Given that we're (almost) always iterating through the result of the
getAll-calls, using aMapseems nicer overall since it's more suited to iteration compared to a regular Object.Also, add a couple of
Dict-checks in existing code touched by this patch, since it really cannot hurt to prevent potential errors in a corrupt PDF document.