Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NameOrNumberTree.getAll to return a Map rather than an Object #13283

Merged

Commits on Apr 22, 2021

  1. Change NameOrNumberTree.getAll to return a Map rather than an Object

    Given that we're (almost) always iterating through the result of the `getAll`-calls, using a `Map` seems nicer overall since it's more suited to iteration compared to a regular Object.
    
    Also, add a couple of `Dict`-checks in existing code touched by this patch, since it really cannot hurt to prevent *potential* errors in a corrupt PDF document.
    Snuffleupagus committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    83f7009 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Re-factor the Catalog._collectJavaScript method slightly

    This patch first of all moves all checking/validation into the `appendIfJavaScriptDict` function, to avoid duplicating it in multiple places. Secondly, also removes what's now an outdated/incorrect comment since we have implemented scripting support.
    Snuffleupagus committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    4ec0a4f View commit details
    Browse the repository at this point in the history