-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve text-selection for Type3 fonts with empty /FontBBox-entries (issue 6605) #13461
Conversation
327cba6
to
678c338
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9ac839ee3728870/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/3054c03a9599f1f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9ac839ee3728870/output.txt Total script time: 25.71 mins
Image differences available at: http://54.67.70.0:8877/9ac839ee3728870/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/3054c03a9599f1f/output.txt Total script time: 29.08 mins
Image differences available at: http://3.101.106.178:8877/3054c03a9599f1f/reftest-analyzer.html#web=eq.log |
…issue 6605) For Type3 fonts where the /CharProcs-streams of the individual glyph starts with a `d1` operator, we can use that to build a fallback bounding box for the font and thus improve text-selection in some cases.
…tent` This is necessary now, since with the previous patch the /FontBBox potentially depends on the contents of the /CharProcs-streams. Note that if `getOperatorList` is called *before* `getTextContent`, this patch doesn't matter since the font is already fully loaded/parsed. However, for e.g. the `text` test-cases this is necessary to ensure correct reference images.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6c8948f10081340/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6c8948f10081340/output.txt Total script time: 3.80 mins Published |
Looks good; thank you for fixing this! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/091d9cedfdc1d9e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://3.101.106.178:8877/03d311731119887/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/091d9cedfdc1d9e/output.txt Total script time: 22.50 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/03d311731119887/output.txt Total script time: 25.96 mins
|
For Type3 fonts where the /CharProcs-streams of the individual glyphs start with a
d1
operator, we can use that to build a fallback bounding box for the font and thus improve text-selection in some cases.Fixes #6605