Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text-selection for Type3 fonts with bogus /FontBBox-entries (issue 14999) #15133

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

This extends PR #13461, by also building a fallback bounding box for Type3 fonts that contain a much too small /FontBBox-entry.

Please note: While this patch improves things overall, copy-and-pasting still doesn't work perfectly for this document. In particular the lowercase letter "c" cannot be selected/copied, however this can be reproduced in both Adobe Reader and PDFium (in Google Chrome) too, which is caused by a lack of proper /ToUnicode-data in the PDF document.

@Snuffleupagus Snuffleupagus linked an issue Jul 5, 2022 that may be closed by this pull request
…issue 14999)

This extends PR 13461, by also building a fallback bounding box for Type3 fonts that contain a much too small /FontBBox-entry.

*Please note:* While this patch improves things overall, copy-and-pasting still doesn't work perfectly for this document. In particular the lowercase letter "c" cannot be selected/copied, however this can be reproduced in both Adobe Reader and PDFium (in Google Chrome) too, which is caused by a lack of proper /ToUnicode-data in the PDF document.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jul 5, 2022

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4f88acb99f9a40e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 5, 2022

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cd798962c708916/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 5, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/4f88acb99f9a40e/output.txt

Total script time: 25.99 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 22
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/4f88acb99f9a40e/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jul 5, 2022

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/cd798962c708916/output.txt

Total script time: 29.34 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks reasonable. Thank you.

@Snuffleupagus Snuffleupagus merged commit 45fafb2 into mozilla:master Jul 5, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jul 5, 2022

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/89b02068c3654e8/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 5, 2022

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/c17e8a84c5b8277/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 5, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/89b02068c3654e8/output.txt

Total script time: 23.13 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 5, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/c17e8a84c5b8277/output.txt

Total script time: 22.94 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-14999 branch July 5, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]TextLayer is incorrect.
3 participants