Don't change options of the globally used PartialEvaluator in the "should render checkbox with fallback font for printing" unit-test
#13472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…should render checkbox with fallback font for printing" unit-test Given that the same `PartialEvaluator`-instance is used for a lot of these unit-tests, manually changing the options in any one test-case could lead to intermittently failing unit-tests since they're run in a random order. To fix this, we simply have to use the existing method to clone the `PartialEvaluator`-instance but with the custom options.
Snuffleupagus
force-pushed
the
checkbox-print-evaluator
branch
from
71375a9
to
af78ba6
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b6092f651926bc5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/13451185746f5f1/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/b6092f651926bc5/output.txt Total script time: 26.03 mins
Image differences available at: http://54.67.70.0:8877/b6092f651926bc5/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/13451185746f5f1/output.txt Total script time: 28.98 mins
Image differences available at: http://3.101.106.178:8877/13451185746f5f1/reftest-analyzer.html#web=eq.log |
calixteman
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the same
PartialEvaluator-instance is used for a lot of these unit-tests, manually changing the options in any one test-case could lead to intermittently failing unit-tests since they're run in a random order.To fix this, we simply have to use the existing method to clone the
PartialEvaluator-instance but with the custom options.