Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't change options of the globally used PartialEvaluator in the "should render checkbox with fallback font for printing" unit-test #13472

Merged
merged 2 commits into from
May 31, 2021
Merged

Don't change options of the globally used PartialEvaluator in the "should render checkbox with fallback font for printing" unit-test #13472

merged 2 commits into from
May 31, 2021

Commits on May 31, 2021

  1. Ensure that the old/new options are correctly combined in `PartialE… 

    …valuator.clone`
    @Snuffleupagus
    Snuffleupagus committed May 31, 2021
    Configuration menu
    Copy the full SHA
    e3bde56 View commit details
    Browse the repository at this point in the history

  2. Don't change options of the globally used PartialEvaluator in the "… 

    …should render checkbox with fallback font for printing" unit-test

Given that the same `PartialEvaluator`-instance is used for a lot of these unit-tests, manually changing the options in any one test-case could lead to intermittently failing unit-tests since they're run in a random order.
To fix this, we simply have to use the existing method to clone the `PartialEvaluator`-instance but with the custom options.
    @Snuffleupagus
    Snuffleupagus committed May 31, 2021
    Configuration menu
    Copy the full SHA
    af78ba6 View commit details
    Browse the repository at this point in the history