Replace element ids with custom attributes in the xfaLayer
#15154
Conversation
|
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/77424c24308f788/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b3a55193ba0b3ff/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/77424c24308f788/output.txt Total script time: 10.56 mins
Image differences available at: http://54.241.84.105:8877/77424c24308f788/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b3a55193ba0b3ff/output.txt Total script time: 13.53 mins
Image differences available at: http://54.193.163.58:8877/b3a55193ba0b3ff/reftest-analyzer.html#web=eq.log |
We want to avoid adding regular `id`s to xfaLayer-elements, since that means that they become "linkable" through the URL hash in a way that's not supported/intended. This could end up clashing with "named destinations", and that could easily lead to bugs; see issue 11499 and PR 11503 for some context. Rather than using `id`s, we'll instead use a *custom* `data-element-id` attribute such that it's still possible to access the DOM-elements directly if needed. *Please note:* This is basically the xfaLayer-equivalent of PR 15057.
|
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3c7a359a44c9c73/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7dc70ef36385196/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3c7a359a44c9c73/output.txt Total script time: 10.58 mins
Image differences available at: http://54.241.84.105:8877/3c7a359a44c9c73/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/7dc70ef36385196/output.txt Total script time: 12.79 mins
Image differences available at: http://54.193.163.58:8877/7dc70ef36385196/reftest-analyzer.html#web=eq.log |
We want to avoid adding regular
ids to xfaLayer-elements, since that means that they become "linkable" through the URL hash in a way that's not supported/intended. This could end up clashing with "named destinations", and that could easily lead to bugs; see issue #11499 and PR #11503 for some context.Rather than using
ids, we'll instead use a customdata-element-idattribute such that it's still possible to access the DOM-elements directly if needed. Please note: This is basically the xfaLayer-equivalent of PR #15057.