Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace element ids with custom attributes in the xfaLayer #15154

Merged
merged 1 commit into from
Jul 10, 2022

Commits on Jul 10, 2022

  1. Replace element ids with custom attributes in the xfaLayer

    We want to avoid adding regular `id`s to xfaLayer-elements, since that means that they become "linkable" through the URL hash in a way that's not supported/intended. This could end up clashing with "named destinations", and that could easily lead to bugs; see issue 11499 and PR 11503 for some context.
    
    Rather than using `id`s, we'll instead use a *custom* `data-element-id` attribute such that it's still possible to access the DOM-elements directly if needed. *Please note:* This is basically the xfaLayer-equivalent of PR 15057.
    Snuffleupagus committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    4b7bf74 View commit details
    Browse the repository at this point in the history