Move binarySearchFirstItem back to the web/-folder (PR 15237 follow-up)
#15313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow-up) This was moved into the `src/display/`-folder in PR 15110, for the initial editor-a11y patch. However, with the changes in PR 15237 we're again only using `binarySearchFirstItem` in the `web/`-folder and it thus seem reasonable to move it back there. The primary reason for moving it back is that `binarySearchFirstItem` is currently exposed in the public API, and we always want to avoid that unless it's either PDF-related functionality or code that simply must be shared between the `src/`- and `web/`-folders. In this case, `binarySearchFirstItem` is a general helper function that doesn't really satisfy either of those alternatives.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7519731c21a8a7d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9d92ce556899dc6/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7519731c21a8a7d/output.txt Total script time: 26.73 mins
Image differences available at: http://54.241.84.105:8877/7519731c21a8a7d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9d92ce556899dc6/output.txt Total script time: 28.55 mins
Image differences available at: http://54.193.163.58:8877/9d92ce556899dc6/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Aug 14, 2022
|
Looks good; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was moved into the
src/display/-folder in PR #15110, for the initial editor-a11y patch. However, with the changes in PR #15237 we're again only usingbinarySearchFirstItemin theweb/-folder and it thus seem reasonable to move it back there.The primary reason for moving it back is that
binarySearchFirstItemis currently exposed in the public API, and we always want to avoid that unless it's either PDF-related functionality or code that simply must be shared between thesrc/- andweb/-folders. In this case,binarySearchFirstItemis a general helper function that doesn't really satisfy either of those alternatives.