Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move binarySearchFirstItem back to the web/-folder (PR 15237 follow-up) #15313

Merged

Commits on Aug 14, 2022

  1. Move binarySearchFirstItem back to the web/-folder (PR 15237 foll…

    …ow-up)
    
    This was moved into the `src/display/`-folder in PR 15110, for the initial editor-a11y patch. However, with the changes in PR 15237 we're again only using `binarySearchFirstItem` in the `web/`-folder and it thus seem reasonable to move it back there.
    The primary reason for moving it back is that `binarySearchFirstItem` is currently exposed in the public API, and we always want to avoid that unless it's either PDF-related functionality or code that simply must be shared between the `src/`- and `web/`-folders. In this case, `binarySearchFirstItem` is a general helper function that doesn't really satisfy either of those alternatives.
    Snuffleupagus committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    0024165 View commit details
    Browse the repository at this point in the history