Fix reading property of null object in chrome extension's updateEmbedElement function #16612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have faced the problem that PDF Viewer extension does not work correctly in the following cases
The error output to the console is as follows
Checking the previous changes,
it looks like the change is from
parentNode.insertBefore(elem, nextSibling)
tonextSibling.before(elem)
.In the case of insertBefore, if nextSibling is null, it is added as the end of the node's child, so it behaves differently.
Therefore, if nextSibling does not exist, adding the node to the end of the child by
parentNode.append
.Reference:
Node.insertBefore()
Element.before()