Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Add the parent tag id (if any) to the serialized editors (bug 1845087) #16916

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

calixteman
Copy link
Contributor

The tag id will be useful in order to update the StructTree when saving the pdf.

…g 1845087)

The tag id will be useful in order to update the StructTree when saving
the pdf.
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0fc405413526155/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/70ca3a4dd63befb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/0fc405413526155/output.txt

Total script time: 4.69 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/70ca3a4dd63befb/output.txt

Total script time: 18.36 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit b903b30 into mozilla:master Sep 8, 2023
3 checks passed
@calixteman calixteman deleted the parent_in_struct_tree branch September 8, 2023 14:26
calixteman added a commit to calixteman/pdf.js that referenced this pull request Sep 11, 2023
…ing a pdf containing newly added annotations (bug 1845087)

When there is no tree, the tags for the new annotions are just put under the root element.
When there is a tree, we insert the new tags at the right place in using the value
of structTreeParentId (added in PR mozilla#16916).
calixteman added a commit to calixteman/pdf.js that referenced this pull request Sep 12, 2023
…ing a pdf containing newly added annotations (bug 1845087)

When there is no tree, the tags for the new annotions are just put under the root element.
When there is a tree, we insert the new tags at the right place in using the value
of structTreeParentId (added in PR mozilla#16916).
calixteman added a commit to calixteman/pdf.js that referenced this pull request Sep 13, 2023
…ing a pdf containing newly added annotations (bug 1845087)

When there is no tree, the tags for the new annotions are just put under the root element.
When there is a tree, we insert the new tags at the right place in using the value
of structTreeParentId (added in PR mozilla#16916).
calixteman added a commit to calixteman/pdf.js that referenced this pull request Sep 14, 2023
…ing a pdf containing newly added annotations (bug 1845087)

When there is no tree, the tags for the new annotions are just put under the root element.
When there is a tree, we insert the new tags at the right place in using the value
of structTreeParentId (added in PR mozilla#16916).
calixteman added a commit to calixteman/pdf.js that referenced this pull request Sep 14, 2023
…ing a pdf containing newly added annotations (bug 1845087)

When there is no tree, the tags for the new annotions are just put under the root element.
When there is a tree, we insert the new tags at the right place in using the value
of structTreeParentId (added in PR mozilla#16916).
calixteman added a commit to calixteman/pdf.js that referenced this pull request Sep 15, 2023
…ing a pdf containing newly added annotations (bug 1845087)

When there is no tree, the tags for the new annotions are just put under the root element.
When there is a tree, we insert the new tags at the right place in using the value
of structTreeParentId (added in PR mozilla#16916).
calixteman added a commit to calixteman/pdf.js that referenced this pull request Sep 16, 2023
…ing a pdf containing newly added annotations (bug 1845087)

When there is no tree, the tags for the new annotions are just put under the root element.
When there is a tree, we insert the new tags at the right place in using the value
of structTreeParentId (added in PR mozilla#16916).
calixteman added a commit to calixteman/pdf.js that referenced this pull request Sep 16, 2023
…ing a pdf containing newly added annotations (bug 1845087)

When there is no tree, the tags for the new annotions are just put under the root element.
When there is a tree, we insert the new tags at the right place in using the value
of structTreeParentId (added in PR mozilla#16916).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants