Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Add the ability to create/update the structure tree when saving a pdf containing newly added annotations (bug 1845087) #16938

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

calixteman
Copy link
Contributor

When there is no tree, the tags for the new annotions are just put under the root element. When there is a tree, we insert the new tags at the right place in using the value of structTreeParentId (added in PR #16916).

src/core/catalog.js Outdated Show resolved Hide resolved
src/core/catalog.js Outdated Show resolved Hide resolved
src/core/worker.js Outdated Show resolved Hide resolved
src/core/worker.js Outdated Show resolved Hide resolved
src/core/catalog.js Outdated Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
src/core/worker.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run all tests and, assuming they all pass, I'll try to do a final review later today.

src/core/struct_tree.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f6c9406b05ef0a6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c1aae20728fd28f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/f6c9406b05ef0a6/output.txt

Total script time: 26.38 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 12
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/f6c9406b05ef0a6/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/c1aae20728fd28f/output.txt

Total script time: 38.28 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 22

Image differences available at: http://54.193.163.58:8877/c1aae20728fd28f/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ab269b5f91e4bb6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d92f4da17ebb267/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/ab269b5f91e4bb6/output.txt

Total script time: 26.98 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 14
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/ab269b5f91e4bb6/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/d92f4da17ebb267/output.txt

Total script time: 37.36 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  errors: 1
  different ref/snapshot: 25

Image differences available at: http://54.193.163.58:8877/d92f4da17ebb267/reftest-analyzer.html#web=eq.log

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully I've not overlooked anything here, since it's a fair amount of code to wrap your head around.

r=me, thank you!

src/core/primitives.js Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
src/core/struct_tree.js Outdated Show resolved Hide resolved
…ing a pdf containing newly added annotations (bug 1845087)

When there is no tree, the tags for the new annotions are just put under the root element.
When there is a tree, we insert the new tags at the right place in using the value
of structTreeParentId (added in PR mozilla#16916).
@calixteman calixteman merged commit 3afb717 into mozilla:master Sep 18, 2023
3 checks passed
@calixteman calixteman deleted the update_struct_tree branch September 18, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants