-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Add the ability to create/update the structure tree when saving a pdf containing newly added annotations (bug 1845087) #16938
Conversation
c0798a5
to
7901e22
Compare
7901e22
to
ebb574e
Compare
ebb574e
to
469202c
Compare
469202c
to
b6feb86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run all tests and, assuming they all pass, I'll try to do a final review later today.
b6feb86
to
5d2225e
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f6c9406b05ef0a6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c1aae20728fd28f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f6c9406b05ef0a6/output.txt Total script time: 26.38 mins
Image differences available at: http://54.241.84.105:8877/f6c9406b05ef0a6/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/c1aae20728fd28f/output.txt Total script time: 38.28 mins
Image differences available at: http://54.193.163.58:8877/c1aae20728fd28f/reftest-analyzer.html#web=eq.log |
5d2225e
to
980a331
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ab269b5f91e4bb6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d92f4da17ebb267/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ab269b5f91e4bb6/output.txt Total script time: 26.98 mins
Image differences available at: http://54.241.84.105:8877/ab269b5f91e4bb6/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d92f4da17ebb267/output.txt Total script time: 37.36 mins
Image differences available at: http://54.193.163.58:8877/d92f4da17ebb267/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully I've not overlooked anything here, since it's a fair amount of code to wrap your head around.
r=me, thank you!
…ing a pdf containing newly added annotations (bug 1845087) When there is no tree, the tags for the new annotions are just put under the root element. When there is a tree, we insert the new tags at the right place in using the value of structTreeParentId (added in PR mozilla#16916).
980a331
to
a8573d4
Compare
When there is no tree, the tags for the new annotions are just put under the root element. When there is a tree, we insert the new tags at the right place in using the value of structTreeParentId (added in PR #16916).