[Editor] Make sure everything is cleaned up when we switch to annotation editor mode #18366
Conversation
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/c32dbcc41cb0974/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0cbf9922f92ab36/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0cbf9922f92ab36/output.txt Total script time: 7.91 mins
|
There was a problem hiding this comment.
Given that we now cleanup consistently, do we still need to explicitly run this code or can we let the updater-invocation handle that instead via its existing cleanup-call?
r=me, with one question; thank you!
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/c32dbcc41cb0974/output.txt Total script time: 18.76 mins
|
calixteman
force-pushed
the
clean_switch_annot
branch
from
47b490c
to
f8ba16a
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/05d4475bc93b0a7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/386a81e543ffce1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/05d4475bc93b0a7/output.txt Total script time: 7.99 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/386a81e543ffce1/output.txt Total script time: 19.40 mins
|
calixteman
force-pushed
the
clean_switch_annot
branch
from
f8ba16a
to
6817532
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ee4cb333d1de11c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f341027f17014b9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/ee4cb333d1de11c/output.txt Total script time: 7.98 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f341027f17014b9/output.txt Total script time: 18.17 mins
|
| @@ -135,6 +135,7 @@ function getSelector(id) { | |||
| async function getRect(page, selector) { | |||
| // In Chrome something is wrong when serializing a `DomRect`, | |||
| // so we extract the values and return them ourselves. | |||
| await page.waitForSelector(selector); | |||
There was a problem hiding this comment.
Thank you for including this! It fixes one of the last few intermittents we had left, and makes the tests that use this utility function safe by default.
No description provided.