Make sure the editor is visible before getting its rect

[calixteman]

No description provided.

[calixteman]

/botio integrationtest

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/054cc16b502c5a6/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/ea5dd8b2edef737/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/054cc16b502c5a6/output.txt

Total script time: 8.05 mins

• Integration Tests: Passed

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/ea5dd8b2edef737/output.txt

Total script time: 19.71 mins

• Integration Tests: FAILED

[timvandermeij]

I think the change is good because I don't see a point in calling getRect on an invisible element in the tests. However, given that the must update an existing annotation intermittent has returned in the Windows logs above (or maybe it was never actually gone after the change in #18366 and it's simply a different issue), and there are some other Windows intermittents above, I'd like to run the Windows tests here a couple of times to make sure that those are at least not caused by this change before merging.

[timvandermeij]

/botio-windows integrationtest

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/7a0c5f232507dff/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/7a0c5f232507dff/output.txt

Total script time: 16.93 mins

• Integration Tests: Passed

[timvandermeij]

/botio-windows integrationtest

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/575d63347075018/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/575d63347075018/output.txt

Total script time: 17.09 mins

• Integration Tests: FAILED

[timvandermeij]

Thank you for improving this! The change looks good, and it seems good to incrementally land improvements and track other issues separately to have a good overview of what's left to do.