-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure the editor is visible before getting its rect #18374
Conversation
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/054cc16b502c5a6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/ea5dd8b2edef737/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/054cc16b502c5a6/output.txt Total script time: 8.05 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ea5dd8b2edef737/output.txt Total script time: 19.71 mins
|
I think the change is good because I don't see a point in calling |
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/7a0c5f232507dff/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/7a0c5f232507dff/output.txt Total script time: 16.93 mins
|
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 1 Live output at: http://54.193.163.58:8877/575d63347075018/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/575d63347075018/output.txt Total script time: 17.09 mins
|
Thank you for improving this! The change looks good, and it seems good to incrementally land improvements and track other issues separately to have a good overview of what's left to do. |
No description provided.