Group and scope the findbar rules using CSS nesting #18568
Conversation
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8ad2c1f7d669cf4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8ad2c1f7d669cf4/output.txt Total script time: 1.03 mins Published |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a99fa62fe79c1ac/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ffc9debbfff0603/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a99fa62fe79c1ac/output.txt Total script time: 8.49 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/ffc9debbfff0603/output.txt Total script time: 19.05 mins
|
timvandermeij
force-pushed
the
css-findbar
branch
from
cd14b89
to
d8705c1
Compare
timvandermeij
force-pushed
the
css-findbar
branch
from
d8705c1
to
0f809a6
Compare
The findbar CSS rules predate the general availability of CSS nesting, which makes them more difficult to understand and change safely. The primary issues are that the findbar rules are spread all over the `viewer.css` file, they share blocks with non-findbar elements and the scope of the rules is sometimes bigger than necessary. This refactoring groups all findbar-related CSS rules together, scoped to the top-level `#findbar` element, for improved overview and isolation. Note that this patch only intends to move the existing rules around and not change any behavior yet, but it does lay the foundation for e.g. making the findbar respect the `browser.uidensity` preference in Firefox in follow-up work. Co-authored-by: Calixte Denizet <calixte.denizet@gmail.com>
timvandermeij
force-pushed
the
css-findbar
branch
from
0f809a6
to
1fcdced
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c5133c705aaff0e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c5133c705aaff0e/output.txt Total script time: 1.03 mins Published |
The findbar CSS rules predate the general availability of CSS nesting, which makes them more difficult to understand and change safely. The primary issues are that the findbar rules are spread all over the
viewer.cssfile, they share blocks with non-findbar elements and the scope of the rules is sometimes bigger than necessary.This refactoring groups all findbar-related CSS rules together, scoped to the top-level
#findbarelement, for improved overview and isolation. Note that this patch only intends to move the existing rules around and not change any behavior yet, but it does lay the foundation for e.g. making the findbar respect thebrowser.uidensitypreference in Firefox in follow-up work.Notes for the reviewer:
#findbarrules in a different part of the file to make the diff easier. Now the deletions and additions can more easily be compared side-by-side while otherwise they would be intertwined.#findbarelement and noticing that the rules in this block are already inactive:Extracts a part of #18385.