Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group and scope the findbar rules using CSS nesting #18568

Merged
merged 1 commit into from
Aug 8, 2024

Commits on Aug 8, 2024

  1. Group and scope the findbar rules using CSS nesting

    The findbar CSS rules predate the general availability of CSS nesting,
    which makes them more difficult to understand and change safely. The
    primary issues are that the findbar rules are spread all over the
    `viewer.css` file, they share blocks with non-findbar elements and the
    scope of the rules is sometimes bigger than necessary.
    
    This refactoring groups all findbar-related CSS rules together, scoped
    to the top-level `#findbar` element, for improved overview and
    isolation. Note that this patch only intends to move the existing rules
    around and not change any behavior yet, but it does lay the foundation
    for e.g. making the findbar respect the `browser.uidensity` preference
    in Firefox in follow-up work.
    
    Co-authored-by: Calixte Denizet <calixte.denizet@gmail.com>
    timvandermeij and calixteman committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1fcdced View commit details
    Browse the repository at this point in the history