[api-minor] Update the minimum supported Node.js version to 20, and only support the Fetch API for "remote" PDF documents in Node.js #18959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
Node-20
branch
2 times, most recently
from
d66951c to
5e94521
Compare
Snuffleupagus
force-pushed
the
Node-20
branch
2 times, most recently
from
ac5c671 to
35dbfb9
Compare
Do you have e.g. a traceback of what's failing? I can have a look to see if we can perhaps easily fix that. |
This comment was marked as resolved.
This comment was marked as resolved.
Snuffleupagus
force-pushed
the
Node-20
branch
from
35dbfb9 to
0d3dd5c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
timvandermeij
added a commit
to timvandermeij/pdf.js
that referenced
this pull request
Nov 3, 2024
The types tests run in Node.js and therefore use Node types for e.g. builtins. However, we didn't explicitly indicate this in `tsconfig.json` (see [1] for more information and [2] for the PR where we found this). Moreover, we didn't explicitly install the most recent version of `@types/node` which implicitly made us fall back to version 14.14.45 (because that was installed as a dependency of other modules) whereas much newer versions are available and we need those after changes in Node.js (see [3] for more information and [4] for the PR where we found this). This commit fixes both issues by explicitly installing and using the most recent Node.js types, which should also avoid future issues with the types tests. [1] TypeStrong/ts-node#1012 [2] mozilla#18237 [3] https://stackoverflow.com/questions/78790943/in-typescript-5-6-buffer-is-not-assignable-to-arraybufferview-or-uint8arr [4] mozilla#18959
Snuffleupagus
force-pushed
the
Node-20
branch
from
0d3dd5c to
bd26c55
Compare
timvandermeij
approved these changes
Nov 3, 2024
There was a problem hiding this comment.
Looks good to me, with the two comments addressed and #18996 resolved. Thanks!
This patch updates the minimum supported environments as follows: - Node.js 20, which was released on 2023-04-18 and has now entered the "Maintenance"-phase; see https://github.com/nodejs/release#release-schedule Furthermore, note also that Node.js 18 will fairly soon reach EOL.
…odule` This allows *synchronous* loading of Node.js modules and (indirectly) packages, thus simplifying the code a fair bit.
…Node.js environments The Fetch API has been supported since Node.js version 18, see https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API#browser_compatibility
…/display/node_stream.js` file After the previous patch these base-classes are only extended once each and they can thus be combined with the final classes.
Snuffleupagus
force-pushed
the
Node-20
branch
from
bd26c55 to
9269fb9
Compare
ryzokuken
pushed a commit
to ryzokuken/pdf.js
that referenced
this pull request
Nov 4, 2024
The types tests run in Node.js and therefore use Node types for e.g. builtins. However, we didn't explicitly indicate this in `tsconfig.json` (see [1] for more information and [2] for the PR where we found this). Moreover, we didn't explicitly install the most recent version of `@types/node` which implicitly made us fall back to version 14.14.45 (because that was installed as a dependency of other modules) whereas much newer versions are available and we need those after changes in Node.js (see [3] for more information and [4] for the PR where we found this). This commit fixes both issues by explicitly installing and using the most recent Node.js types, which should also avoid future issues with the types tests. [1] TypeStrong/ts-node#1012 [2] mozilla#18237 [3] https://stackoverflow.com/questions/78790943/in-typescript-5-6-buffer-is-not-assignable-to-arraybufferview-or-uint8arr [4] mozilla#18959
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f6cd146445c9fbe/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8ff76d9de7c3070/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f6cd146445c9fbe/output.txt Total script time: 32.27 mins
Image differences available at: http://54.241.84.105:8877/f6cd146445c9fbe/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/8ff76d9de7c3070/output.txt Total script time: 46.07 mins
|
|
This PR seems to break semver? If the minimum nodejs version is now 20, the package version should be now changed 5.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[api-minor] Update the minimum supported Node.js version to 20
This patch updates the minimum supported environments as follows:
Furthermore, note also that Node.js 18 will fairly soon reach EOL.
[api-minor] Load Node.js packages/polyfills with
process.getBuiltinModuleThis allows synchronous loading of Node.js modules and (indirectly) packages, thus simplifying the code a fair bit.
[api-minor] Only support the Fetch API for "remote" PDF documents in Node.js environments
The Fetch API has been supported since Node.js version 18, see https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API#browser_compatibility
Remove the
BaseFullReaderandBaseRangeReaderclasses in thesrc/display/node_stream.jsfileAfter the previous patch these base-classes are only extended once each and they can thus be combined with the final classes.
Edit: I intend to submit this for review after the upcoming release.