-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Webpack from resolving import.meta.url
statements during building (issue 19145)
#19149
Conversation
…ilding (issue 19145) This fixes a Node.js-specific regression from PR 18959.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/20fb2845cc9c7d2/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/eeb6776be78ed99/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/eeb6776be78ed99/output.txt Total script time: 27.71 mins
Image differences available at: http://54.241.84.105:8877/eeb6776be78ed99/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/20fb2845cc9c7d2/output.txt Total script time: 48.07 mins
|
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified locally that this produces working builds.
Without this patch PDF.js is basically unusable in Node.js, which means that the regression is bad enough that for once I do think that we should consider an immediate follow-up release to address this. @timvandermeij What's your opinion on this? |
This comment was marked as spam.
This comment was marked as spam.
Thank you for the fix!
I agree with this. I'll make a new release in a bit. |
This fixes a Node.js-specific regression from PR #18959.