Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Webpack from resolving import.meta.url statements during building (issue 19145) #19149

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

This fixes a Node.js-specific regression from PR #18959.

…ilding (issue 19145)

This fixes a Node.js-specific regression from PR 18959.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/20fb2845cc9c7d2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/eeb6776be78ed99/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/eeb6776be78ed99/output.txt

Total script time: 27.71 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/eeb6776be78ed99/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/20fb2845cc9c7d2/output.txt

Total script time: 48.07 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

@kailashyogeshwar85

This comment was marked as spam.

Copy link
Contributor

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally that this produces working builds.

@Snuffleupagus
Copy link
Collaborator Author

Without this patch PDF.js is basically unusable in Node.js, which means that the regression is bad enough that for once I do think that we should consider an immediate follow-up release to address this.

@timvandermeij What's your opinion on this?

@aovens-quantifi

This comment was marked as spam.

@timvandermeij timvandermeij merged commit a4eb840 into mozilla:master Dec 5, 2024
9 checks passed
@timvandermeij
Copy link
Contributor

Thank you for the fix!

What's your opinion on this?

I agree with this. I'll make a new release in a bit.

@Snuffleupagus Snuffleupagus deleted the issue-19145 branch December 5, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot load "@napi-rs/canvas" package: "Error: Cannot find module '@napi-rs/canvas'
6 participants