Fix for bind compatibility implementation (polyfill) #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, reconstruction of arguments was incorrect if arguments contained arrays. Arrays were added to arguments as their elements and not as a whole array. It is enough to simply pass whole array to concat and it will be (only one level deep) added to arguments. In addition, we call slice on arguments for maximum compatibility (it is used in Underscore.js library, with which I was comparing implementations while debugging).
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/df5b92b1e7303ea/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/df5b92b1e7303ea/output.txt Total script time: 0.34 mins Published
|
yurydelendik
added a commit
that referenced
this pull request
Feb 18, 2014
Fix for bind compatibility implementation (polyfill)
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, reconstruction of arguments was incorrect if arguments contained arrays. Arrays were added to arguments as their elements and not as a whole array. It is enough to simply pass whole array to concat and it will be (only one level deep) added to arguments.
In addition, we call slice on arguments for maximum compatibility (it is used in Underscore.js library, with which I was comparing implementations while debugging).