-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the unavailable linked test-case for issue 4436 with a reduced test-case #6434
Replace the unavailable linked test-case for issue 4436 with a reduced test-case #6434
Conversation
…d test-case Issue 4436 actually contains enough information to create a reduced test-case, which this patch uses to replace a currently unavailable linked test.
I'm having trouble verifying this reduced test case. Take for example the preview from #4299 and open the reduced test case in Opera and Chrome. I always see the line, before and after the patch that fixed the issue mentioned here. @Snuffleupagus Were you able to verify the test case in either browser and if so, what steps did you take? |
Unfortunately I wasn't. Please let me elaborate on why I submitted this PR, despite that. What I did was simply to use the information given in #4436 (comment) verbatim, in order to build this reduced test-case. Since trying to download the current linked test-case fails when done from our test suite (the request is blocked by the server), I figured that it was better to have a reduced test-case available rather than an unnecessary test failures for people who try to test locally. |
I was just able to verify the reduced test case with Opera 20.0.1387.64 as mentioned in the original issue. Fortunately Opera offers download links to older versions. With automatic zoom, the line is not visible, whereas if I zoom the line becomes visible. Now that this is verified, I'm much more comfortable merging this. |
@brendandahl @yurydelendik Any idea what's going on with the Linux bot? |
I gave it a restart earlier. I think it may be low on space for '/'. I'll check a bit later if we can free up some space. |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/287b1e65ec366ed/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c8a792df75dad4f/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/287b1e65ec366ed/output.txt Total script time: 18.70 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c8a792df75dad4f/output.txt Total script time: 19.97 mins
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/292347fda39fcfd/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/aa0700f15b3ec26/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/292347fda39fcfd/output.txt Total script time: 18.79 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/aa0700f15b3ec26/output.txt Total script time: 19.45 mins
|
Replace the unavailable linked test-case for issue 4436 with a reduced test-case
Thank you! |
Issue #4436 actually contains enough information to create a reduced test-case, which this patch uses to replace a currently unavailable linked test.