Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the unavailable linked test-case for issue 4436 with a reduced test-case #6434

Merged
merged 1 commit into from
Oct 12, 2015
Merged

Replace the unavailable linked test-case for issue 4436 with a reduced test-case #6434

merged 1 commit into from
Oct 12, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

Issue #4436 actually contains enough information to create a reduced test-case, which this patch uses to replace a currently unavailable linked test.

…d test-case

Issue 4436 actually contains enough information to create a reduced test-case, which this patch uses to replace a currently unavailable linked test.
@timvandermeij
Copy link
Contributor

I'm having trouble verifying this reduced test case. Take for example the preview from #4299 and open the reduced test case in Opera and Chrome. I always see the line, before and after the patch that fixed the issue mentioned here. @Snuffleupagus Were you able to verify the test case in either browser and if so, what steps did you take?

@Snuffleupagus
Copy link
Collaborator Author

Were you able to verify the test case in either browser and if so, what steps did you take?

Unfortunately I wasn't. Please let me elaborate on why I submitted this PR, despite that.
If I'm reading #4436 (comment) correctly, it seems that this issue was specific to older versions of Chromium browsers, hence it's possible that it has been fixed since then.

What I did was simply to use the information given in #4436 (comment) verbatim, in order to build this reduced test-case. Since trying to download the current linked test-case fails when done from our test suite (the request is blocked by the server), I figured that it was better to have a reduced test-case available rather than an unnecessary test failures for people who try to test locally.
Provided that the information in that comment is accurate, the reduced test-case should be good.

@timvandermeij
Copy link
Contributor

I was just able to verify the reduced test case with Opera 20.0.1387.64 as mentioned in the original issue. Fortunately Opera offers download links to older versions. With automatic zoom, the line is not visible, whereas if I zoom the line becomes visible.

Now that this is verified, I'm much more comfortable merging this.

@timvandermeij
Copy link
Contributor

@brendandahl @yurydelendik Any idea what's going on with the Linux bot?

@brendandahl
Copy link
Contributor

I gave it a restart earlier. I think it may be low on space for '/'. I'll check a bit later if we can free up some space.

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/287b1e65ec366ed/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c8a792df75dad4f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/287b1e65ec366ed/output.txt

Total script time: 18.70 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/c8a792df75dad4f/output.txt

Total script time: 19.97 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/292347fda39fcfd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/aa0700f15b3ec26/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/292347fda39fcfd/output.txt

Total script time: 18.79 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/aa0700f15b3ec26/output.txt

Total script time: 19.45 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

timvandermeij added a commit that referenced this pull request Oct 12, 2015
Replace the unavailable linked test-case for issue 4436 with a reduced test-case
@timvandermeij timvandermeij merged commit c4403e6 into mozilla:master Oct 12, 2015
@timvandermeij
Copy link
Contributor

Thank you!

@Snuffleupagus Snuffleupagus deleted the issue-4436-reduced-test branch October 13, 2015 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants