Improve the annotation code by converting to ES6 syntax and removing duplicate code #8828
Conversation
This corresponds to how other factories are implemented.
avoid duplication in subclasses
Aside from being up-to-date, this may improve build time/size.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/48b325418f82db2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/48b325418f82db2/output.txt Total script time: 2.34 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6bada02823374bb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/45289dbc7a405e6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/6bada02823374bb/output.txt Total script time: 16.44 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/45289dbc7a405e6/output.txt Total script time: 29.34 mins
|
There was a problem hiding this comment.
Really nice diff stats, that's a lot of boilerplate code being removed at once :-D
One thing though: The IRC discussion only seem to explicitly mention src/display/, and this PR would be the first case where we're using ES6 classes in src/core.
Since the annotations, if present, will be always be parsed during the getOperatorList call, I'm not sure if that's a cause for (theoretical) concern?
Although, looking at https://bugzilla.mozilla.org/show_bug.cgi?id=1167472, a number of performance improvements have already landed.
Given that the number of annotations present on any one page is usually not very large, I'd be surprised if these changes made any difference at all (performance wise).
So, tentatively r=me; but I'd like @yurydelendik to confirm that he's OK with this before we land it.
Improve the annotation code by converting to ES6 syntax and removing duplicate code
The annotation code is not performance-sensitive, so we may convert this code to ES6 syntax (see http://logs.glob.uno/?c=mozilla%23pdfjs&s=23+Aug+2017&e=23+Aug+2017#c66446). Refer to the individual commits for more information about each change.
Using https://github.com/mozilla/pdf.js/pull/8828/files?w=1 helps reviewing tremendously.