Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the annotation code by converting to ES6 syntax and removing duplicate code #8828

Merged
merged 5 commits into from
Aug 30, 2017
Merged

Improve the annotation code by converting to ES6 syntax and removing duplicate code #8828

merged 5 commits into from
Aug 30, 2017

Commits on Aug 26, 2017

  1. Convert src/core/annotation.js to ES6 syntax

    @timvandermeij
    timvandermeij committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    24d741d View commit details
    Browse the repository at this point in the history

  2. Convert src/display/annotation_layer.js to ES6 syntax

    @timvandermeij
    timvandermeij committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    af10f8b View commit details
    Browse the repository at this point in the history

  3. Let the two annotation factories use static methods 

    This corresponds to how other factories are implemented.
    @timvandermeij
    timvandermeij committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    4f02857 View commit details
    Browse the repository at this point in the history

  4. Implement getOperatorList method in the WidgetAnnotation class to 

    avoid duplication in subclasses
    @timvandermeij
    timvandermeij committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    2512ecc View commit details
    Browse the repository at this point in the history

  5. Update webpack and webpack-stream to the latest version 

    Aside from being up-to-date, this may improve build time/size.
    @timvandermeij
    timvandermeij committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    7787987 View commit details
    Browse the repository at this point in the history