Prevent errors in sanitizeTTProgram, during parsing of CALL functions, when encountering invalid functions stack deltas (bug 1473809)
#9886
Conversation
…ns, when encountering invalid functions stack deltas (bug 1473809) *I was feeling bored; so this is a very quick, and somewhat naive, attempt at fixing the bug.* The breaking error, i.e. `Error during font loading: invalid array length`, was thrown when attempting to re-size the `stack` to a *negative* length when parsing the CALL functions. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1473809.
Snuffleupagus
changed the title
sanitizeTTProgram, during parsing of CALL functio…ns, when encountering invalid functions stack deltas (bug 1473809)sanitizeTTProgram, during parsing of CALL functions, when encountering invalid functions stack deltas (bug 1473809)
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/17234c76acaf667/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/09d03a6fb945e98/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/17234c76acaf667/output.txt Total script time: 0.55 mins |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/09d03a6fb945e98/output.txt Total script time: 0.65 mins |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4dc6c850f7ff323/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/37296492bb7720f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/4dc6c850f7ff323/output.txt Total script time: 0.55 mins |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/37296492bb7720f/output.txt Total script time: 0.55 mins |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/5c5962cfcfe81eb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/44c7092a0326ca3/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/44c7092a0326ca3/output.txt Total script time: 24.68 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/5c5962cfcfe81eb/output.txt Total script time: 37.83 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/fcb8d7eef2a85c9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/fcb8d7eef2a85c9/output.txt Total script time: 18.99 mins Published |
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/f80ddf3fb07589a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6492b1da987bbf3/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/f80ddf3fb07589a/output.txt Total script time: 22.09 mins
|
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/6492b1da987bbf3/output.txt Total script time: 60.00 mins
|
|
/botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/18dce15f3a98dae/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/18dce15f3a98dae/output.txt Total script time: 60.00 mins
|
|
Thank you for fixing this! I'm opening a follow-up issue to track the failed makeref on the Linux bot. |
Thanks for merging!
Good idea; the Linux-only failures look like general slowness of the bot, since even something as simple as |
|
/botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1700e9a66d01c73/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/1700e9a66d01c73/output.txt Total script time: 0.10 mins |
|
/botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4f3ab9b7eab3eab/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4f3ab9b7eab3eab/output.txt Total script time: 18.21 mins
|
I was feeling bored; so this is a very quick, and somewhat naive, attempt at fixing the bug.
The breaking error, i.e.
Error during font loading: invalid array length, was thrown when attempting to re-size thestackto a negative length when parsing the CALL functions.Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1473809.