This repository has been archived by the owner on May 10, 2019. It is now read-only.
Allow SVG siteLogos to be specified as data: URIs #4181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only legitimate MIME type for SVGs is "image/svg+xml", but our whitelist contained "image/svg" instead. As a result, data-URI encoded SVGs were not allowed as the siteLogo.
|
Code looks good, r+. Logic for the change makes sense too. If you expected me to run this code YOU'RE OUTTA YOUR MIND and should let me know to run the code. |
| ); | ||
| }); | ||
|
|
||
|
|
There was a problem hiding this comment.
Also wtf is with this new github comment style it's freaking me out
|
self-merging into future |
|
Fixed in c80fe2f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only legitimate MIME type for SVGs is "image/svg+xml", but our whitelist
contained "image/svg" instead.
As a result, data-URI encoded SVGs were not allowed as the siteLogo.