Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

NODE_ENV=test_mysql node tests/stalled-mysql-test.js failing with Travis(0.10.31) and anything(0.10.30) #4179

Closed
jrgm opened this issue Aug 22, 2014 · 6 comments · Fixed by #4205

Comments

@jrgm
Copy link
Contributor

jrgm commented Aug 22, 2014

See: https://travis-ci.org/mozilla/persona/jobs/32913897

and

[12:56:37] travis-ci: [travis-ci] mozilla/persona#4291 (dev - e1e7f30 : Dan Callahan): The build failed.
[12:56:37] travis-ci: [travis-ci] Change view : 08e2212...e1e7f30
[12:56:37] travis-ci: [travis-ci] Build details : http://travis-ci.org/mozilla/persona/builds/32913895
[13:40:33] callahad: jrgm: By the way, node 0.10.31 should fixes the stalled-mysql-test.js failures. nodejs/node-v0.x-archive@6f04394
[13:41:11] callahad: Not sure why that test run still fails
[13:41:55] callahad: re-runs locally
[13:42:59] jrgm: callahad: yeah, I had tracked down that same commit. But 0.10.31 didn't seem to fix it for me on linux.
[13:44:27] jrgm: callahad: I was just about to file an issue to track, but then it passed with 0.10.31 on osx for me
[13:47:39] callahad: jrgm: Hrm. That whole test run passes on OS X for me, too
[13:48:03] jrgm: callahad: ... and now it passes for me on linux. So why fail on Travis with 0.10.31? (blah, blah, clocks, blah, blah, multi-tenant, blah, blah, ubuntu, ..)
[13:48:54] callahad: goes to build 10.31 on Debian

@hemanth
Copy link

hemanth commented Aug 23, 2014

Same issue. @jbonacci

@callahad
Copy link
Contributor

Whoops, the mass-closing script misfired. Reopening.

@abendigo
Copy link
Contributor

abendigo commented Nov 9, 2014

I have found the problem. In stalled-mysql-tests.js,
STALL_MYSQL_WHEN_PRESENT is set to point to a non-existent directory,
and so addStallDriverBatch fails to create the .stall file. I will try to find a fix, and submit a pull request.

@abendigo
Copy link
Contributor

abendigo commented Nov 9, 2014

Woohoo! Bumping the version of the temp module seemed to fix it! As soon as my branches travis build passes, I will submit a Pull Request.

@callahad
Copy link
Contributor

callahad commented Nov 9, 2014

Hah! You're kidding? That's awesome :)

@abendigo
Copy link
Contributor

abendigo commented Nov 9, 2014

Pull Request submitted: #4204

callahad pushed a commit that referenced this issue Nov 9, 2014
Bump up the version of the temp module.
callahad added a commit that referenced this issue Nov 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants