Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Fixes #4179. tests/stalled-mysql-test.js failing. #4204

Closed
wants to merge 2 commits into from
Closed

Fixes #4179. tests/stalled-mysql-test.js failing. #4204

wants to merge 2 commits into from

Conversation

abendigo
Copy link
Contributor

@abendigo abendigo commented Nov 9, 2014

Bump up the version of the temp module.

Bump up the version of the temp module.
@callahad
Copy link
Contributor

callahad commented Nov 9, 2014

Could you please run ./node_modules/.bin/lockdown-relock to regenerate the lockdown.json? Otherwise, Lockdown will be sad.

@abendigo
Copy link
Contributor Author

abendigo commented Nov 9, 2014

When I run that, it make a lot more changes than I am expecting to lockdown.json

@callahad
Copy link
Contributor

callahad commented Nov 9, 2014

Huh, so it does. It shouldn't.

Let me try this locally...

@callahad
Copy link
Contributor

callahad commented Nov 9, 2014

I'll be damned. Works here. Works on Travis. I'll relock and manually merge.

I'm facepalming so hard right now -- saw the regression in Node 0.10.30 and it completely blinded me to other possible causes. THANK YOU! 🍻

@abendigo
Copy link
Contributor Author

abendigo commented Nov 9, 2014

No worries. I am hoping this wont be my only contribution to this project.

@callahad callahad mentioned this pull request Nov 9, 2014
@callahad
Copy link
Contributor

callahad commented Nov 9, 2014

Likewise :) I'm going to close this and merge in #4205, which includes a working relock.

I have to drop offline for a bit, but I'll merge as soon as I get back.

Normally I'd be curious about why your lockdown wasn't hashing things on relock, but instead, I'd like to just move to NPM's built-in shrinkwrap (#4184).

If you want to do more NPM plumbing work, that could be good :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants