Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify _v toggle to a string per data source #130

Closed
alison985 opened this issue Jul 17, 2017 · 4 comments
Closed

Modify _v toggle to a string per data source #130

alison985 opened this issue Jul 17, 2017 · 4 comments
Assignees
@alison985
Milestone
7

Comments

@alison985
Copy link

alison985 commented Jul 17, 2017 •
edited
Loading

Before this ticket: on the query creation page you could click the "toggle" icon above the schema browser to remove any table with the string '_v' in its name from the list.

This ticket changes: the string in a table name that the "toggle" button uses to remove tables from the list is now set on each data source configuration page.
@rafrombrc rafrombrc added this to the 7 milestone Jul 19, 2017
@alison985 alison985 self-assigned this Jul 24, 2017
alison985 added a commit to alison985/mozilla-redash that referenced this issue Jul 24, 2017
@alison985
add toggle_table_string
ba7e0ed 
addresses mozilla#130

Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.

Not in postgres query_runner because then test_interactive_new fails.
@alison985 alison985 mentioned this issue Jul 24, 2017
Merged
@alison985
Copy link
Author

PR #147

alison985 added a commit to alison985/mozilla-redash that referenced this issue Jul 27, 2017
@alison985
fix table toggle from datasource config
e03c1a5 
with fixes for doc_url (not needed lines removed) and

mozilla#130
@alison985 alison985 mentioned this issue Jul 27, 2017
Merged
@alison985
Copy link
Author

PR #170

@alison985 alison985 reopened this Jul 27, 2017
@alison985
Copy link
Author

On staging (https://pipeline-sql.stage.mozaws.net/data_sources/1) the Mozilla metadata data source has a toggle table string of '_v' for testing purposes.

@alison985
Copy link
Author

There are now several components to this feature.

  1. You can set a toggle table string for a data source. Each data source can have a different table toggle string.
    Login, go to the data sources list page, click on the mozilla metadata data source. You can add, edit, or remove the table toggle string in the configuration of the data source. For testing purposes it should be '_v' on staging.

  2. On the query creation page you can toggle tables into or out of the table list by clicking the toggle icon at the top of the table list if there is a table toggle string specified for that data source.
    Login, go to the query creation page, select the mozilla metadata data source in the drop down menu. You should see the toggle icon above the browser schema. Click it to remove tables that contain '_v' in their name from the list of tables. Click it again to return those tables to the list.

alison985 added a commit to alison985/mozilla-redash that referenced this issue Aug 18, 2017
@alison985
add toggle_table_string
3918d1d 
addresses mozilla#130

Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.

Not in postgres query_runner because then test_interactive_new fails.
alison985 added a commit to alison985/mozilla-redash that referenced this issue Aug 18, 2017
@alison985
fix table toggle from datasource config
7b001cd 
with fixes for doc_url (not needed lines removed) and

mozilla#130
washort pushed a commit that referenced this issue Dec 12, 2017
@alison985
add toggle_table_string (re #130)
571b1b2 
Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.
washort pushed a commit that referenced this issue Dec 12, 2017
@alison985
add toggle_table_string (re #130)
25a4ff1 
Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.
washort pushed a commit that referenced this issue Dec 13, 2017
@alison985
(fixup) add toggle_table_string
d2abf1e 
addresses #130

Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.

Not in postgres query_runner because then test_interactive_new fails.
washort pushed a commit that referenced this issue Jan 8, 2018
@alison985
add toggle_table_string (re #130)
29c6cf5 
Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.
washort pushed a commit that referenced this issue Jan 17, 2018
@alison985
add toggle_table_string (re #130)
056aea2 
Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.
washort pushed a commit that referenced this issue Feb 6, 2018
@alison985
add toggle_table_string (re #130)
f09e6f8 
Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.
washort pushed a commit that referenced this issue Feb 28, 2018
@alison985
add toggle_table_string (re #130)
9fa98ba 
Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.
jezdez pushed a commit that referenced this issue Mar 5, 2018
@alison985 @jezdez
add toggle_table_string (re #130)
55a3e90 
Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.
washort pushed a commit that referenced this issue Apr 4, 2018
Filter versioned table names only (re #130) (re #356)
1f1117d
emtwo pushed a commit that referenced this issue May 25, 2018
@alison985
add toggle_table_string (re #130)
4a32829 
Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.
emtwo pushed a commit that referenced this issue May 25, 2018
Filter versioned table names only (re #130) (re #356)
a65c7f6
@washort washort mentioned this issue Jul 9, 2018
Closed
@alison985 alison985 mentioned this issue Oct 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alison985 alison985

Labels
None yet
Projects
None yet
Milestone
7
Development

No branches or pull requests
2 participants
@rafrombrc @alison985