Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

130 modify toggle string to per data source #147

Merged

Conversation

alison985
Copy link

addresses #130

Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.

Not in postgres query_runner because then test_interactive_new fails.

@alison985 alison985 requested a review from washort July 24, 2017 05:01
@alison985 alison985 added this to the 7 milestone Jul 24, 2017
addresses mozilla#130

Makes the _v of the schema browser toggle into a configurable string
per data source. It is not required and if it is not filled in the
toggle will not appear in the schema browser.

Not in postgres query_runner because then test_interactive_new fails.
@washort
Copy link

washort commented Jul 25, 2017

r+

Here's my fix for the postgres test: washort@9b663c0

@alison985 alison985 merged commit 45aa946 into mozilla:master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants