Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop build for current target should not pass --target #10

Closed
thomcc opened this issue Jul 17, 2019 · 1 comment
Closed

Desktop build for current target should not pass --target #10

thomcc opened this issue Jul 17, 2019 · 1 comment

Comments

@thomcc
Copy link
Contributor

thomcc commented Jul 17, 2019

E.g. on darwin we shouldn't pass --target=x86_64-apple-darwin. Doing prevents us from reusing anything in either sccache or cargo's dep cache.
@ncalexan
Copy link
Member

Mmm. I vaguely recall doing this for consistency. It's especially annoying 'cuz the names and directory structure of Cargo's output change with and without an explict --target. But you're absolutely right, we should not pass --target for the current target.

thomcc pushed a commit to thomcc/rust-android-gradle-1 that referenced this issue Aug 5, 2019
Avoid passing --target to cargo for the default target. Fixes mozil…
44c4214 
…la#10
@thomcc thomcc mentioned this issue Aug 5, 2019
Merged
thomcc pushed a commit to thomcc/rust-android-gradle-1 that referenced this issue Aug 19, 2019
Avoid passing --target to cargo for the default target. Fixes mozil…
3b26ec0 
…la#10
@thomcc thomcc closed this as completed in 445abc6 Aug 20, 2019
@thomcc thomcc mentioned this issue Apr 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomcc @ncalexan