Improve target handling #11
Merged
+89
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncalexan
requested changes
Aug 6, 2019
thomcc
force-pushed
the
target-handling
branch
from
7e2e719 to
2fc34ec
Compare
ncalexan
approved these changes
Aug 14, 2019
| /** Attempt to get the default (desktop) target triple by parsing `rustc -Vv` output. */ | ||
| private fun computeDefaultTargetTriple(): String? { | ||
| val runtime = Runtime.getRuntime() | ||
| // Do we need to worry about the env (specifically PATH) here? |
There was a problem hiding this comment.
We have a cargoCommand and a pythonCommand. Can we determine this version from cargoCommand?
There was a problem hiding this comment.
AFAIK, we cannot. I'll add rustcCommand.
There was a problem hiding this comment.
Actually, I think doing this would prevent us from caching the output. Hmm, let me think if there's a problem with that.
There was a problem hiding this comment.
Okay, All the caching code is gone, we just invoke it every time based on the extension configuration. It's not fatal for us to fail to locate it, we'll just pass --target explicitly and warn.
thomcc
force-pushed
the
target-handling
branch
from
da27c05 to
3b26ec0
Compare
|
I've cleaned up the commit history as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9 and #10.
The complexity is mainly in the fix for #10, to avoiding invoking
rustc --version --verboseonce per task. It completes somewhat quickly, but we often have a lot of tasks. Ideally we'd just use a Lazy, static ctor, or some other way of doing the same thing we do automatically, but our need to pass in the Project prevents this.I also improved the documentation for
targetDirectoryin the fix for #10, since it didn't explain when you might want to use it, and i think the example could be confusing (since there's areleasefolder inside the target directory).