-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure on macOS with rustc 1.25.0 #233
Comments
Wouldn't you know, I disabled CI coverage of Mac with nightly Rust a while ago (because Travis Mac jobs take forever to run). I'm not sure I would have noticed this anyway given that I have nightly CI set to allow failures. If the app_dirs fix lands and gets released I will absolutely merge a PR to update to the fixed version. |
I fixed this by removing |
This broke the mac Rust 1.21 build: Apparently directories is using the |
I bumped the minimum supported Rust version to 1.22: |
The `app_dirs` crate has become unmaintained and is broken on macOS with Rust 1.25. The `directories` crate provides the same functionality and is maintained, so switch to using that instead.
sccache fails to build with rustc 1.25.0 or newer on macOS:
This is reported to the app_dirs dependency in andybarron/app-dirs-rs#28 and was caused by rust-lang/rust#46985. According to the rustc issue rust-lang/rust#48716 this will not be reverted, and a patch to app_dirs is necessary. One exists, but appears to have stalled, in andybarron/app-dirs-rs#29.
The text was updated successfully, but these errors were encountered: