Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use profile-generate to replace outdated -Zprofile options #2282

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Nov 6, 2024

Related to mozilla/grcov#1240

I start this PR to fix the main branch's CI failure, but find out that we need to use profile-generate to replace outdated -Zprofile options.

Refer https://doc.rust-lang.org/rustc/profile-guided-optimization.html for more information.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Nov 6, 2024

cc @sylvestre would you like to take a look? This PR will address the failing CI on main.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title ci: Remove outdated -Zprofile options feat: Use profile-generate to replace outdated -Zprofile options Nov 6, 2024
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Collaborator Author

Xuanwo commented Nov 6, 2024

Snap workflow has been disable since it never works.

https://github.com/mozilla/sccache/actions/runs/11701499882/job/32587729982?pr=2282

Exported credentials are no longer valid for the Snap Store.
Recommended resolution: Run export-login and update SNAPCRAFT_STORE_CREDENTIALS.
For more information, check out: https://snapcraft.io/docs/snapcraft-authentication
Full execution log: '/home/runner/.local/state/snapcraft/log/snapcraft-20241106-102321.213818.log'

@sylvestre sylvestre merged commit f4da228 into main Nov 6, 2024
110 of 111 checks passed
@Xuanwo Xuanwo deleted the fix-ci branch November 6, 2024 10:43
@sylvestre
Copy link
Collaborator

thanks !

@glandium
Copy link
Collaborator

I think we should revert this change because:

  • It broke support for command lines that contain any other -Z flag
  • It broke support for -Zprofile, which may still be used with older version of rustc
  • It tracks a profraw file that is irrelevant: it would be the equivalent to gcda, not gcno. And actually it never exists, because even when the program is run and a profraw file is generated, its name is different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants