Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: Use profile-generate to replace outdated -Zprofile options" #2297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sylvestre
Copy link
Collaborator

Reverts #2282

@Xuanwo
Copy link
Collaborator

Xuanwo commented Dec 19, 2024

Hi, reverting this will break all stable Rust. I believe it's better to provide forward compatibility instead, allowing sccache to also accept -Z simultaneously.

@sylvestre
Copy link
Collaborator Author

@Xuanwo sorry for the lack of context. It caused some significant regressions in term of build for firefox:
https://bugzilla.mozilla.org/show_bug.cgi?id=1937804

@Xuanwo
Copy link
Collaborator

Xuanwo commented Dec 19, 2024

@Xuanwo sorry for the lack of context. It caused some significant regressions in term of build for firefox: bugzilla.mozilla.org/show_bug.cgi?id=1937804

Got it. Let me find sometime tomorrow to see how can we fix this.

@glandium
Copy link
Collaborator

See my comment in #2282. Considering the support for --profile-generate is wrong, fixing the whole thing is going to amount to essentially revert this and reintroduce --profile-generate in a simpler form. All in all, it's going to be simpler to start from the reverted state.

@sylvestre
Copy link
Collaborator Author

@Xuanwo have you been able to have a look?
Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants