Replace usage of jsonwebtoken for GCS #578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of the patched jsonwebtoken
jsonwebtoken = { git = "https://github.com/Jake-Shadle/jsonwebtoken.git", rev = "2f469a61" }
which is still needed due to no release from jsonwebtoken with the relevant changes (last release was May). Using patches are supposed to be temporary, because what ends up happening is that people that do
cargo install sccache --features=gcs
end up with a broken sccache because the patched version of jsonwebtoken that "works" is not used when installing from crates.io, and for some reason, the prebuilt binaries (at least the musl one) in github releases are also incorrect.Rather than wait for a release, this change removes the need for jsonwebtoken altogether for
gcs
caching, by just doing the relevant pieces directly using base64/ring.jsonwebtoken is still used in the dist stuff, only required 2 changes due to a field being removed from JWT.
Resolves: #489