-
Notifications
You must be signed in to change notification settings - Fork 96
feat: Upgrade Airflow from 2.9.3 to 2.10.5 (DENG-5881) #2179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…g present in v12.0.0. The bug was Dataproc operators failing to import without OpenLineage, fixed in apache/airflow#46561.
| @@ -1 +1 @@ | |||
| apache-airflow-providers-cncf-kubernetes==8.3.4 | |||
| apache-airflow-providers-google==14.0.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned that in the (lengthy) PR description:
And that's mentioned in the commit message for b0bc472 (which should also end up in the final squashed merge commit message).
However, I agree it would be helpful for the reason for the override to be more obvious so you don't have to Git blame to find the reason. I'll add an explanatory comment in requirements-override.txt (and IMO going forward we should have a convention of always adding comments for such overrides).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also FYI, there are some additional package dependency changes caused by forcing this upgrade (though none seem consequential):
-apache-airflow-providers-common-compat==1.3.0
+apache-airflow-providers-common-compat==1.5.1
-apache-airflow-providers-google==12.0.0
+apache-airflow-providers-google==14.0.0
-google-cloud-build==3.29.0
+google-cloud-build==3.31.1
+google-cloud-managedkafka==0.1.9
+joblib==1.4.2
+scikit-learn==1.6.1
+scipy==1.15.2
+threadpoolctl==3.6.0
+tqdm==4.67.1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changing?
In case you were also wondering why the apache-airflow-providers-cncf-kubernetes==8.3.4 override is being removed, we had forced an upgrade to that version to get a bug fix, and now Airflow 2.10.5 comes with apache-airflow-providers-cncf-kubernetes 10.1.0 by default, which includes that bug fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add an explanatory comment in requirements-override.txt (and IMO going forward we should have a convention of always adding comments for such overrides).
Great idea
|
With this PR deployed to staging I successfully tested the following DAGs:
|
Description
Some notable changes...
Airflow (upgrading from 2.9.3 to 2.10.5)
try_numberis no longer incremented during task execution (#39336).reattach_on_restartto work more reliably.apache-airflow-providers-amazon(upgrading from 8.25.0 to 9.2.0)apache-airflow-providers-cncf-kubernetes(upgrading from 8.3.3 to 10.1.0)do_xcom_pushandget_logsfunctionality forKubernetesJobOperator(#40814).KubernetesPodOperator(#43853).KubernetesPodOperator(#44428).apache-airflow-providers-google(upgrading from 10.21.0 to 14.0.0)BigQueryAsyncHook.create_job_for_partition_get(#44225).BigQueryTablePartitionExistenceSensors to run in reschedule mode, and this will allow us to revert to running them in deferrable mode.apache-airflow-providers-http(upgrading from 4.12.0 to 5.0.0)SimpleHttpOperator, which one of our DAGs was using.apache-airflow-providers-postgres(upgrading from 5.11.2 to 6.0.0)apache-airflow-providers-slack(upgrading from 8.7.1 to 9.0.0)Related Tickets & Documents