Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the 'ext-types/guid' fixture to 'ext-types/custom-types' #2072

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

mhammond
Copy link
Member

I always get a little confused about where exactly our tests are for "custom types" before I re-remember they are hidden inside a crate called 'guid'. I've got some custom type tests and fixes stacked up, and thought I'd fix this first, which will make future patches easier to read.

@mhammond mhammond requested a review from a team as a code owner April 15, 2024 14:55
@mhammond mhammond requested review from bendk and removed request for a team April 15, 2024 14:55
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@mhammond mhammond merged commit 15a3473 into mozilla:main Apr 15, 2024
5 checks passed
@mhammond mhammond deleted the rename-guid-fixture branch April 15, 2024 18:53
@bendk bendk mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants