Changes for the 0.27.2
#2102
Merged
Changes for the 0.27.2
#2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are alternate versions of the current scaffolding functions that use u64 buffers to handle their input/output. The main use case is the gecko-js bindings used in Firefox. This allows us to replace the generated C++ code with static code, since the scaffolding functions now always have the exact same signature. This commit generates FFI buffer versions for scaffolding functions defined for user functions/methods. It does not generate them for functions with known/static signatures like the rust buffer FFI functions, or the object clone/delete functions. If the signature is always the same, then there isn't a problem calling the normal scaffolding functions.
This is needed because we haven't merged mozilla#2083 into the branch. Also: - Added a changelog entry. - Added a `#[allow(unknown_lints)]`, since `clippy::needless_borrows_for_generic_args` is not available on the older Rust version used in this branch.
Implemented our own oneshot channel using a Mutex. It's not quite as efficient as the `oneshot` one, but I think it should be fine for our purposes. My gut feeling is that the loss of overhead is neglibable compared the other existing overhead that UniFFI adds. The API of the new oneshot is basically the same, except send/recv are not failable.
mhammond
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping to get these changes released so that Firefox can consume them. Does this make sense for a 0.27.2 release? Are there any other changes that should go in there?