Python: Fix custom types generating invalid code when there are forward references #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
force-pushed
the
python-forward-references
branch
2 times, most recently
from
e574c6c to
9d81c65
Compare
bendk
approved these changes
Apr 16, 2024
| None => ordered.push((name, builtin)), | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this could maybe fail if there were multiple levels of builtins, eg:
A { builtin: C},
B { }
C { builtin: B }
would get sorted to
C { builtin: B }
A { builtin: C},
B { }
That seems pretty pathological for custom types and I think it's probably fine to ignore. How about adding a note mentioning this? That way we don't repurpose the algo for a situation where it would matter.
…rd references. Also includes many other custom-type tests, all of which work, and clarifies in the docs about which types can be used with custom types. Fixes mozilla#2067
mhammond
force-pushed
the
python-forward-references
branch
from
9d81c65 to
b97c6dd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes many other custom-type tests, all of which work, and clarifies in the docs about which types can be used with custom types.
Fixes #2067