Add more functionality to get_custom_type_aliases sorting #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
approved these changes
May 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to consume the change from #2075 today and noticed that it didn't cover my use case, where a type alias is used as the key for a HashMap which also is an alias. I added a test showing this and made a change to the sorting algorithm to fix this.
The current algorithm for ordering type aliases is: "if the typename I'm inserting into the sorted list is the type for something already in the list, put this item in front of it".
My proposed new algorithm is: "if the typename I'm inserting into the sorted list is included in the nested types for something already in the list, put this item in front of it".