Changes for v0.28.1 #2213
Merged
Changes for v0.28.1 #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify pointer alignment for `Handle`
The method is used from outside of this module, so the comment seems unnecessary: the method should either be private or it should be public.
The method is not meant to be used outside of the crate.
…d-proc-macros Remote types: interfaces and proc macros ADR
`Option<&T>` was never supported as far as I can tell. I added some tests on top of e10a7f9, where that documentation was added and it didn't work.
…t`. (mozilla#2173) `error_buf` is owned by the foreign side. Because we assume it has been initialized we use `ManuallyDrop` instead of `MaybeUninit`, which clarifies ownership and avoids unsafe code. Fixes mozilla#2168
…lla#2171) Co-authored-by: Jan-Erik Rediger <janerik@fnordig.de>
…entries` usage on `Kotlin >= 1.9.0` and keep backwards compatibility with previous versions
…r-enums Kotlin: use `Enum.entries` instead of `Enum.values()`
We're moving towards making this an optional dependency.
Don't use cargo_metadata to parse version numbers
This avoids crashing for consumers that set panic=abort (Firefox). - Updated the Err type for `rust_call`. The closure can now return an internal error. The only way to signal an internal error before was to panic. - Reworked the `LowerReturn` trait and the future code to work with the new system. - Added a type for argument lift errors, this makes the rustfuture signatures nicer.
…re all unsafe. (mozilla#2192) Fixes mozilla#2164
Don't panic for try_lift errors
…eature. (mozilla#2200) The `uniffi_test` crate unconditionally depends on `cargo_metadata`, and this will be difficult to change. This means that because `uniffi_test` is an unconditional dependency of `uniffi_bindgen`, the `cargo_metadata` feature doesn't actually prevent `uniffi_bindgen` from depending on `cargo_metadata`. The top level `uniffi` create already has a feature `bindgen-tests`. This patch introduces a feature of the same name to `uniffi_bindgen`. Enabling that feature also enables the metadata feature. This means that if you do not enable either of these features you should be able to avoid `cargo_metadata`. This patch also renames the new `cargo_metadata` feature to be `cargo-metadata` to be more consistent with our existing features and Rust feature naming in general.
…lla#2201) This continues the cargo_metadata feature work but making the execution of cargo_metadata the resonsibility of the uniffi_bindgen callers rather that executing it implicitly. This means the CLI, which in-turn means the top-level uniffi crate also gets a `cargo-metadata` feature. This reverts what we did to fix mozilla#2183 - by making `no_deps` the default, it means we will be unable to support reuse of UniFFI components, because it means we only support all components being in the same workspace. While this is a common use-case, it's not the only use-case we want to support. So grabbing all dependencies from cargo_metadata is again the default, but there's a new command-line option to avoid it. It also replaces some of mozilla#2195.
…lla#2195) * Thread `ExternalType` metadata into RustBuffer In service of Java bindgen being able to generate fully qualified `RustBuffer`s when necessary. * Switch to `test --no-run` from `build` for cdylib `uniffi-bindgen-java` is external to the uniffi repo, so the fixtures/examples are all `dev-dependencies`, which aren't built on a call to `cargo build`. `cargo test --no-run` causes them to be built but doesn't cause a run of tests in place.
Replace templating filters for Python
I'm hoping to do a 0.28.1 release and these would be good to have in it. I also considered adding an entry for the work that mgeisler has been doing, but I couldn't think of a good wording for that.
Adding changelog entries for merges since 0.28.0
The generate_bindings docs mentioned wanting to expose a function that just finds ComponentInterface and config tables for each component and leaves the rest to the external bindings generator. This is exactly what I want to use for uniffi-bindgen-gecko-js. The `find_components` function was pretty much exactly what we wanted. I made some minor changes to it and exposed it as a pub function.
Expose the find_components function
mhammond
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping to make a 0.28.1 release from the latest
main. There's a lot of commits here, but no breaking changes. In fact, most of the commits are documentation related or refactorings that don't change any behavior.