Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency chrome-launcher to v0.12.0 #1745

Merged
merged 2 commits into from
Dec 24, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 30, 2019

This PR contains the following updates:

Package Type Update Change
chrome-launcher dependencies minor 0.11.2 -> 0.12.0

Release Notes

GoogleChrome/chrome-launcher

v0.12.0

Compare Source

  • 66a5e226 flags: add new --disable flags to reduce noise and disable backgrounding (#​170)
    • --disable-component-extensions-with-background-pages
    • --disable-backgrounding-occluded-windows
    • --disable-renderer-backgrounding
    • --disable-background-timer-throttling
  • c4890ee3 feat: expose public interface for locating Chrome installations (#​177)
    • Launcher.getInstallations() returns an array of paths to available Chrome binaries
  • a5ccaa4e deps: update assorted dependencies (#​175)
  • e67a10df --disable-translation is now --disable-features=TranslateUI (#​167)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.

@coveralls
Copy link

coveralls commented Oct 30, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling b66cda2 on renovate/chrome-launcher-0.x into 2286ca1 on master.

@rpl rpl self-requested a review December 6, 2019 10:16
@renovate renovate bot force-pushed the renovate/chrome-launcher-0.x branch from 382af9f to 815d7a9 Compare December 9, 2019 14:15
@renovate renovate bot force-pushed the renovate/chrome-launcher-0.x branch from 815d7a9 to 3ccc08a Compare December 10, 2019 13:44
@rpl
Copy link
Member

rpl commented Dec 10, 2019

this now fails as expected on the new test case added in #1775:
https://travis-ci.org/mozilla/web-ext/jobs/623186250#L912-L932

And the diff provided in the failure is useful to actually know what has changed:

 AssertionError: expected [ Array(10) ] to deeply equal [ Array(6) ]

      + expected - actual

       [
      -  "--disable-features=TranslateUI"
      -  "--disable-component-extensions-with-background-pages"
      +  "--disable-translate"
         "--disable-background-networking"
         "--disable-sync"
         "--metrics-recording-only"
         "--disable-default-apps"
         "--no-first-run"
      -  "--disable-backgrounding-occluded-windows"
      -  "--disable-renderer-backgrounding"
      -  "--disable-background-timer-throttling"

@renovate renovate bot force-pushed the renovate/chrome-launcher-0.x branch from 3ccc08a to 69c5c22 Compare December 24, 2019 12:08
@renovate
Copy link
Contributor Author

renovate bot commented Dec 24, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@rpl rpl merged commit d9878f0 into master Dec 24, 2019
@renovate renovate bot deleted the renovate/chrome-launcher-0.x branch December 24, 2019 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants