fix: Removed default '--mute-audio' flag for chromium

[jezhou]

Fixes #1774

[coveralls]

Coverage remained the same at 100.0% when pulling b77f064 on jezhou:jz/fix-mute-audio-chrome-flag into 23913db on mozilla:master.

[rpl]

@jezhou thanks for creating this pull request so quickly :-)
(I'm pretty sure that I marked the issue as a good first bug just yesterday :-P)

[jezhou]

Added the test; I also slightly refactored so that there's only one source of truth for the expected default flags. I mentioned it briefly above, but I believe the flags we want until we update to 12.0 are in 11.2, which can be found here.

[jezhou]

Something I also want to ask about is that sometimes when I run the tests, this.wss.address() seems to return null. I'm working on a macOS, with node v13.2.0 and npm 6.13.1.

This is from an extension I'm playing around with:

I'm not sure if there's something I'm missing in the setup. If this is a separate issue I can file it if needed

[rpl]

Something I also want to ask about is that sometimes when I run the tests, this.wss.address() seems to return null. I'm working on a macOS, with node v13.2.0 and npm 6.13.1.
...
This is from an extension I'm playing around with:
...
I'm not sure if there's something I'm missing in the setup.

@jezhou does it also happen on other node version in your system, or just with nodejs v13?

If this is a separate issue I can file it if needed

yes, would you mind to file a separate issue, it looks unexpected and we should take a look into it (but I've briefly tried and I can't reproduce on my system by just running the tests on nodejs v13, I have to come back to it for further investigations)

[rpl]

Looks good to me, just a small nit (related to making easier to maintain the flags to filter out over the time).

[jezhou]

@jezhou does it also happen on other node version in your system, or just with nodejs v13?

I also tried it on nodejs v10 with no success. I'll probably try a few combinations to see if I can get it to work, and file an issue sometime tonight 🙂

Edit: Hmmm... I restarted my computer and it now sometimes works with v13. Still doesn't consistently work with v10 though. In any case, I filed an issue 👉 #1779

[caitmuenster]

Thanks for the patch, @jezhou! 🙌🏼 Your contribution has been added to our recognition wiki.

Would you be interested in creating an account on mozillians.org? I'd be happy to vouch for you!

[jezhou]

@caitmuenster Sure 🙂 I just made an account here https://mozillians.org/en-US/u/jezhou/

[caitmuenster]

Awesome, you're vouched. Welcome onboard! I look forward to seeing you around the project. :)