Fix reaper exhausting the queue #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After max queue size connections have been reaped, no new connections are allowed to be created.
mperham
reviewed
Aug 7, 2024
| @@ -178,6 +178,8 @@ def reap_idle_connections(idle_seconds, reap_start_time, &reap_block) | |||
| while idle_connections?(idle_seconds, reap_start_time) | |||
| conn, _last_checked_out = @que.shift | |||
| reap_block.call(conn) | |||
| # Decrement created unless this is a no create stack | |||
| @created -= 1 unless @max == 0 | |||
There was a problem hiding this comment.
Does this need a mutex or synchronization?
There was a problem hiding this comment.
This method operates within a mutex block, so it's clear here.
However, looking over how this is currently setup, there could be resource contention issues with the reaper trying to close connections when something else decides it wants a connection from the pool. I think I'll take a quick stab at trying to improve that in another PR. This one is nice and simple and fixes an actual bug.
|
Merged as part of #189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After max queue size connections have been reaped, no new connections are allowed to be created.
I'm am not sure how intended the 0 pool size behavior is. The tests make a lot of use of it but it seems counter to normal use.