Avoid extra mutex contention #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After max queue size connections have been reaped, no new connections are allowed to be created.
The connection shutdown block can safely happen outside the mutex. This allows another thread to safely grab a connection while the reaper is still working through old connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This includes the commit from #188 so I didn't have to deal with wonky rebasing.
This limits the mutex lock to interactions with the stack that are small, fast, and atomic. Moving the connection close code outside the mutex as it doesn't impact the pool.
Sidenote: Thinking about releasing the reap update, it probably needs to be a major version bump as it breaks things for anyone that has used the defined extension points and interacts with
@que. It is probably possible this could be modified to only introduce a breaking change ifreapis used.