fix: removes htmlEncode function for phenogrid #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisco-ebi
approved these changes
Dec 3, 2024
|
Merge it at your convenience 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Monarch App update v1.10.0 fixed the following phenogrid issues:
Fix
The current change removes the encoding that was placed as a temporary measure for the first issue.
This measure allowed to pass special characters from mouse models ("<", ">", "&") into the tooltips of the Phenogrid without losing information. The downside was the labels on the x-axis would display the characters instead of the formatted mouse model description.
With the changes from Monarch, encoding is no longer necessary.