Generics review the code and UT fixes #79

mpostol · Jul 18, 2018 · bb1aac3 · bb1aac3
1 parent 96729b3
commit bb1aac3
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 13 deletions.
diff --git a/Lecture/P01.Introduction/Introduction.UnitTest/ConstructorInjectionUnitTest.cs b/Lecture/P01.Introduction/Introduction.UnitTest/ConstructorInjectionUnitTest.cs
@@ -6,9 +6,9 @@
 //____________________________________________________________________________
 
 using Microsoft.VisualStudio.TestTools.UnitTesting;
-using TP.DependencyInjection.UnitTest.Instrumentation;
+using TP.Introduction.Instrumentation;
 
-namespace TP.DependencyInjection
+namespace TP.Introduction
 {
   [TestClass]
   public class ConstructorInjectionUnitTest

diff --git a/Lecture/P01.Introduction/Introduction.UnitTest/PropertyInjectionUnitTest.cs b/Lecture/P01.Introduction/Introduction.UnitTest/PropertyInjectionUnitTest.cs
@@ -8,8 +8,9 @@
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using System;
 using System.Diagnostics;
+using TP.Introduction.Instrumentation;
 
-namespace TP.DependencyInjection
+namespace TP.Introduction
 {
   [TestClass]
   public class PropertyInjectionUnitTest

diff --git a/Lecture/P2.DataSemantics/DataSemantics/DataSemantics.csproj b/Lecture/P2.DataSemantics/DataSemantics/DataSemantics.csproj
@@ -20,6 +20,7 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <NoWarn>IDE0001,IDE0002,IDE0003</NoWarn>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
@@ -43,14 +44,14 @@
     <Compile Include="AnonymousTypes.cs" />
     <Compile Include="BasicTypesStruct.cs" />
     <Compile Include="FileExample.cs" />
+    <Compile Include="Generics\Generics.cs" />
+    <Compile Include="Generics\Node.cs" />
+    <Compile Include="Generics\NodeEnumerable.cs" />
     <Compile Include="InterfaceExample.cs" />
-    <Compile Include="LessonGenerics\Generics.cs" />
-    <Compile Include="LessonGenerics\Node.cs" />
-    <Compile Include="LessonGenerics\NodeEnumerable.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
   </ItemGroup>
   <ItemGroup>
-    <None Include="LessonGenerics\Generics.md" />
+    <None Include="Generics\Generics.md" />
   </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
 </Project>
diff --git a/Lecture/P2.DataSemantics/DataSemantics/Generics/Generics.cs b/Lecture/P2.DataSemantics/DataSemantics/Generics/Generics.cs
@@ -8,7 +8,7 @@
 using System;
 using System.Collections.Generic;
 
-namespace TP.DataSemantics.LessonGenerics
+namespace TP.DataSemantics.Generics
 {
   /// <summary>
   /// Class Generics - an example og generics.

diff --git a/Lecture/P2.DataSemantics/DataSemantics/Generics/Node.cs b/Lecture/P2.DataSemantics/DataSemantics/Generics/Node.cs
@@ -5,7 +5,7 @@
 //  To be in touch join the community at GITTER: https://gitter.im/mpostol/TP
 //____________________________________________________________________________
 
-namespace TP.DataSemantics.LessonGenerics
+namespace TP.DataSemantics.Generics
 {
   public class Node<ValueTypeParameter>
   {

diff --git a/Lecture/P2.DataSemantics/DataSemantics/Generics/NodeEnumerable.cs b/Lecture/P2.DataSemantics/DataSemantics/Generics/NodeEnumerable.cs
@@ -8,7 +8,7 @@
 using System.Collections;
 using System.Collections.Generic;
 
-namespace TP.DataSemantics.LessonGenerics
+namespace TP.DataSemantics.Generics
 {
   public class NodeEnumerable<ValueTypeParameter> : Node<ValueTypeParameter>, IEnumerable<ValueTypeParameter>
   {

diff --git a/Lecture/P2.DataSemantics/DataSemanticsUnitTest/DataSemanticsUnitTest.csproj b/Lecture/P2.DataSemantics/DataSemanticsUnitTest/DataSemanticsUnitTest.csproj
@@ -28,6 +28,7 @@
     <DefineConstants>DEBUG;TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
+    <NoWarn>IDE0001,IDE0002,IDE0003</NoWarn>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>

diff --git a/Lecture/P2.DataSemantics/DataSemanticsUnitTest/GenericsUnitTest.cs b/Lecture/P2.DataSemantics/DataSemanticsUnitTest/GenericsUnitTest.cs
@@ -7,7 +7,7 @@
 
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using System;
-using TP.DataSemantics.LessonGenerics;
+using TP.DataSemantics.Generics;
 
 namespace TP.DataSemantics
 {
@@ -24,13 +24,11 @@ public void AfterCreationValueTestMethod()
     public void AfterCreationReferenceTestMethod()
     {
       Generics<AnyClass> _intInstance = new Generics<AnyClass>();
-      //Assert.AreEqual<int>(0, _intInstance.DefaultValue);
       Assert.IsNull(_intInstance.DefaultValue);
     }
     [TestMethod]
     public void DictionaryCreatorTestMethod()
     {
-      //SelfDictionary<AnyClass> _dictionPrim = new SelfDictionary<AnyClass>();
       SelfDictionary<EquatableNotImplemented> _dictionSecond = new SelfDictionary<EquatableNotImplemented>();
     }
     [TestMethod]