Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generics review the code and UT #79

Closed
mpostol opened this issue May 21, 2018 · 2 comments
Closed

Generics review the code and UT #79

mpostol opened this issue May 21, 2018 · 2 comments
Assignees
@mpostol
Labels
enhancement it is possible to improve the example In progress
Milestone
Review existing code

Comments

@mpostol
Copy link
Owner

mpostol commented May 21, 2018

Review the Generics example to make sure it covers all aspects of this topic.
@mpostol mpostol added the enhancement it is possible to improve the example label May 21, 2018
@mpostol mpostol added this to the Backlog milestone May 21, 2018
@mpostol mpostol self-assigned this May 21, 2018
@mpostol mpostol modified the milestones: Backlog, Cleanup and make release May 21, 2018
@mpostol mpostol mentioned this issue May 27, 2018
Closed
mpostol referenced this issue May 27, 2018
@mpostol
Generics review the code and UT - working copy
a6ce5f2 
- type parameter must be added type - added proof
- refactoring UT
- UT all green.
mpostol referenced this issue May 27, 2018
@mpostol
Generics review the code and UT - working copy
a40abbc 
- added markdown with notes
- refactoring text
@mpostol
Copy link
Owner Author

mpostol commented May 27, 2018

It takes over the Generics - add example #16
Mark #16 as duplicated.

mpostol added a commit that referenced this issue Jun 3, 2018
@mpostol
Generics review the code and UT #79
416761a 
- added new example Node
- refactoring class Generics - only unimportant changes
mpostol added a commit that referenced this issue Jun 3, 2018
@mpostol
Generics review the code and UT #79
7ea9d16 
- created new folder for generisc example
mpostol added a commit that referenced this issue Jun 4, 2018
@mpostol
Generics review the code and UT #79
1c2ca58 
- added new example NodeObservable.cs
mpostol added a commit that referenced this issue Jun 6, 2018
@mpostol
Generics review the code and UT #79
4a3f477 
- changed the file name NodeObservable.cs to NodeEnumerable.cs
- Now the class is derived from Node.cs
- it is working copy
- UT green
@mpostol
Copy link
Owner Author

mpostol commented Jun 6, 2018

  • Review the code.
  • Remove Generics class and move all examples to a class derived from NodeEnumerable<ValueTypeParameter>
  • Add unit tests
    Now it is moved to standby stage.

@mpostol mpostol modified the milestones: Backlog, Review existing code Jul 17, 2018
mpostol added a commit that referenced this issue Jul 18, 2018
@mpostol
Generics review the code and UT #79
96729b3 
- refactoring names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpostol mpostol

Labels
enhancement it is possible to improve the example In progress
Projects
None yet
Milestone
Review existing code
Development

No branches or pull requests
1 participant
@mpostol