Fix shadow #10845
Merged
Fix shadow #10845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c326466.
Conflicts: src/renderers/webgl/WebGLShadowMap.js
|
I'm trying to move around things in the renderer so it can handle materials being used by different types of objects 😅 |
|
This is proving to be a little bit too complicated... I'll merge this for now and try again in the next cycle... |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes shadow issue #10836
Currently material can't be shared between normal
MeshandSkinnedMesh(#10754),so we need to separate depth/distance materials for them.
@lo-th
@RemusMar
Would you guys check if all the problems you ran into are solved with this change?