WebGLRenderer: Optimize number of light shadow uniforms. #18627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Point light shadow uniforms are now in a separate struct so they don't need to be included in case shadows are not enabled. This makes it possible to use more shadowless lights on platforms that have low limits for uniform count. It was experimentally verified that this change makes a difference on 7th gen iPad with iPadOS 13.3.1.
The shaders only contain code for active shadows, so they don't need a separate flag to determine whether the shadow is enabled.
In terms of overall performance or being able to make the scene more complex? |
Mugen87
changed the title
I was able to significantly increase the number of shadowless point lights in the scene on iPad after this change without running into shader compilation issues. |
Mugen87
approved these changes
Feb 18, 2020
|
Lets merge this in r115. I guess this will break |
|
Well, I've tested all node examples and they work fine^^. @sunag Could this change still affect |
|
@Mugen87 No problem for me. |
|
Lets merge it now then! YOLO 😁 |
|
Thanks! |
|
Thanks for merging this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Light shadow uniforms are now in a separate struct so they don't need to be included in case shadows are not enabled.
This makes it possible to use more shadowless lights on platforms that have low limits for uniform count.
It was experimentally verified that this change makes a difference on 7th gen iPad with iPadOS 13.3.1.